Hardens realm instance usage

app/src/main/java/net/pokeranalytics/android/ui/fragment/BankrollFragment.kt

@@ -73,6 +73,7 @@ class BankrollFragment : RealmFragment(), StaticRowRepresentableDataSource, RowR
 	// Life Cycle
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_bankroll, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/CalendarFragment.kt

@@ -74,6 +74,7 @@ class CalendarFragment : SessionObserverFragment(), CoroutineScope, StaticRowRep
 	// Life Cycle
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(net.pokeranalytics.android.R.layout.fragment_calendar, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/DataListFragment.kt

@@ -48,6 +48,7 @@ class DataListFragment : RealmFragment(), LiveRowRepresentableDataSource, RowRep
 	private var lastItemClickedPosition: Int = 0
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_data_list, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/EditableDataFragment.kt

@@ -42,6 +42,7 @@ open class EditableDataFragment : RealmFragment(), RowRepresentableDelegate {
 	var shouldOpenKeyboard = true
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_editable_data, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/FeedFragment.kt

@@ -62,6 +62,7 @@ class FeedFragment : RealmFragment(), RowRepresentableDelegate {
 	private var selectedTransactionPosition: Int = -1
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_feed, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/FilterDetailsFragment.kt

@@ -51,6 +51,7 @@ open class  FilterDetailsFragment : RealmFragment(), StaticRowRepresentableDataS
 	private var shouldOpenKeyboard = true
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_filter_details, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/FiltersFragment.kt

@@ -42,6 +42,7 @@ open class FiltersFragment : RealmFragment(), StaticRowRepresentableDataSource,
 	private var isUpdating = false
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_filters, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/GraphFragment.kt

@@ -63,6 +63,7 @@ class GraphFragment : RealmFragment(), OnChartValueSelectedListener {
 	private var axisFormatting: AxisFormatting = AxisFormatting.DEFAULT
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_graph, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/SessionFragment.kt

@@ -65,6 +65,7 @@ class SessionFragment : RealmFragment(), RowRepresentableDelegate {
 	}
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+		super.onCreateView(inflater, container, savedInstanceState)
 		return inflater.inflate(R.layout.fragment_session, container, false)
 	}
 

app/src/main/java/net/pokeranalytics/android/ui/fragment/components/RealmFragment.kt

@@ -8,7 +8,7 @@ import io.realm.Realm
 
 open class RealmFragment : PokerAnalyticsFragment() {
 
-	private var realm: Realm? = null
+	private lateinit var realm: Realm
 
 	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
 		realm = Realm.getDefaultInstance()
@@ -17,20 +17,14 @@ open class RealmFragment : PokerAnalyticsFragment() {
 
 	override fun onDestroyView() {
 		super.onDestroyView()
-		this.realm?.close()
+		this.realm.close()
 	}
 
 	/**
 	 * Get the realm instance
 	 */
 	fun getRealm(): Realm {
-		this.realm?.let {
-			return it
-		} ?: run {
-			val realm = Realm.getDefaultInstance()
-			this.realm = realm
-			return realm
-		}
+		return this.realm
 	}
 
 }

app/src/main/java/net/pokeranalytics/android/ui/fragment/components/SessionObserverFragment.kt

@@ -1,6 +1,9 @@
 package net.pokeranalytics.android.ui.fragment.components
 
 import android.os.Bundle
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
 import io.realm.RealmResults
 import net.pokeranalytics.android.model.realm.ComputableResult
 
@@ -8,12 +11,16 @@ open class SessionObserverFragment : RealmFragment() {
 
     private lateinit var endedSessions: RealmResults<ComputableResult>
 
-	override fun onCreate(savedInstanceState: Bundle?) {
-		super.onCreate(savedInstanceState)
+	override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
+
+		val view = super.onCreateView(inflater, container, savedInstanceState)
+
 		this.endedSessions = getRealm().where(ComputableResult::class.java).findAll() // ComputableResult are existing only if sessions are ended
 		this.endedSessions.addChangeListener { _, _ ->
 			this.sessionsChanged()
 		}
+
+		return view
 	}
 
 	override fun onDestroyView() {