Fixes bug in Builder

hh
Laurent 6 years ago
parent b1fa2d9020
commit 506c4bd931
  1. 19
      app/src/main/java/net/pokeranalytics/android/model/handhistory/HHBuilder.kt
  2. 2
      app/src/main/res/values-de/strings.xml
  3. 2
      app/src/main/res/values-es/strings.xml
  4. 2
      app/src/main/res/values-fr/strings.xml
  5. 2
      app/src/main/res/values-hi/strings.xml
  6. 2
      app/src/main/res/values-it/strings.xml
  7. 2
      app/src/main/res/values-ja/strings.xml
  8. 2
      app/src/main/res/values-pt/strings.xml
  9. 2
      app/src/main/res/values-ru/strings.xml
  10. 12
      app/src/main/res/values-v24/strings.xml
  11. 2
      app/src/main/res/values-zh/strings.xml

@ -160,7 +160,10 @@ class HHBuilder {
when (actionType) { when (actionType) {
Action.Type.CALL -> { Action.Type.CALL -> {
val significantAmount = getLastSignificantAction(index)?.action?.amount ?: throw PAIllegalStateException("Cannot happen") val significantAction = getLastSignificantAction(index)
?: throw PAIllegalStateException("There must be a previously set significant action for a call to be set")
val significantAmount = significantAction.action.amount
?: throw PAIllegalStateException("There must be a set amount on the action for the call to be set")
val committedAmount = getPreviousCommittedAmount(index) ?: 0.0 val committedAmount = getPreviousCommittedAmount(index) ?: 0.0
computedAction.setEffectiveAmount(significantAmount - committedAmount) computedAction.setEffectiveAmount(significantAmount - committedAmount)
} }
@ -181,8 +184,8 @@ class HHBuilder {
* We want drop all non-auto added rows after the index * We want drop all non-auto added rows after the index
*/ */
private fun dropNextActionsIfNecessary(index: Int) { private fun dropNextActionsIfNecessary(index: Int) {
val dropIndex = index + 1 // TODO determine dropIndex // val dropIndex = index + 1 // TODO determine dropIndex
this.sortedActions.drop(dropIndex) // this.sortedActions = this.sortedActions.take(dropIndex)
} }
/*** /***
@ -235,7 +238,7 @@ class HHBuilder {
val position = action.position val position = action.position
val street = action.street val street = action.street
val previousActions = this.sortedActions.drop(index) val previousActions = this.sortedActions.take(index)
val previousComputedAction = previousActions.lastOrNull { val previousComputedAction = previousActions.lastOrNull {
it.action.position == position && it.action.street == street it.action.position == position && it.action.street == street
} }
@ -257,7 +260,9 @@ class HHBuilder {
*/ */
private fun getLastUserAction(index: Int): ComputedAction? { private fun getLastUserAction(index: Int): ComputedAction? {
val action = this.actionForIndex(index).action val action = this.actionForIndex(index).action
val previousActions = this.sortedActions.drop(index) Timber.d("**** this.sortedActions.size = ${this.sortedActions.size}")
val previousActions = this.sortedActions.take(index)
Timber.d("**** this.sortedActions.size = ${this.sortedActions.size}")
return previousActions.lastOrNull { it.action.position == action.position } return previousActions.lastOrNull { it.action.position == action.position }
} }
@ -265,7 +270,9 @@ class HHBuilder {
* Returns the last significant player action, if any, for the action at the provided [index] * Returns the last significant player action, if any, for the action at the provided [index]
*/ */
private fun getLastSignificantAction(index: Int): ComputedAction? { private fun getLastSignificantAction(index: Int): ComputedAction? {
val previousActions = this.sortedActions.drop(index) Timber.d("**** this.sortedActions.size = ${this.sortedActions.size}")
val previousActions = this.sortedActions.take(index)
Timber.d("**** this.sortedActions.size = ${this.sortedActions.size}")
return previousActions.lastOrNull { it.action.isActionSignificant } return previousActions.lastOrNull { it.action.isActionSignificant }
} }

@ -703,7 +703,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -704,7 +704,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -772,7 +772,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -703,7 +703,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -703,7 +703,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -703,7 +703,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -702,7 +702,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -704,7 +704,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

@ -1,12 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="poker_rumble">Poker Rumble</string>
<string name="discord_feed_message">We\'ve opened our Discord channel! Come to hang out, talk about poker or about the app!</string>
<string name="good_for_you">Good for you!</string>
<string name="posts_sb">posts</string>
<string name="post_bb">posts</string>
<string name="fold">fold</string>
<string name="straddle">straddle</string>
<string name="check">check</string>
<string name="call">check</string>
</resources>

@ -698,7 +698,7 @@
<string name="fold">fold</string> <string name="fold">fold</string>
<string name="straddle">straddle</string> <string name="straddle">straddle</string>
<string name="check">check</string> <string name="check">check</string>
<string name="call">check</string> <string name="call">call</string>
<string name="bet">bet</string> <string name="bet">bet</string>
<string name="raise">raise</string> <string name="raise">raise</string>
<string name="allin">allin</string> <string name="allin">allin</string>

Loading…
Cancel
Save