fix issues with club

PadelClub.xcodeproj/project.pbxproj

@@ -1908,7 +1908,7 @@
 				ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
 				CODE_SIGN_ENTITLEMENTS = PadelClub/PadelClub.entitlements;
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 65;
+				CURRENT_PROJECT_VERSION = 66;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				DEFINES_MODULE = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"PadelClub/Preview Content\"";
@@ -1949,7 +1949,7 @@
 				ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
 				CODE_SIGN_ENTITLEMENTS = PadelClub/PadelClub.entitlements;
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 65;
+				CURRENT_PROJECT_VERSION = 66;
 				DEFINES_MODULE = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"PadelClub/Preview Content\"";
 				DEVELOPMENT_TEAM = BQ3Y44M3Q6;

PadelClub/Data/Club.swift

@@ -170,7 +170,7 @@ class Club : ModelObject, Storable, Hashable {
 
 extension Club {
     var isValid: Bool {
-        name.isEmpty == false && acronym.isEmpty == false
+        name.isEmpty == false && name.count > 3
     }
     
     func automaticShortName() -> String {
@@ -216,7 +216,7 @@ extension Club {
     }
     
     func hasBeenCreated(by creatorId: String?) -> Bool {
-        return creatorId == creator
+        return creatorId == creator || creator == nil
     }
     
     func isFavorite() -> Bool {
@@ -235,7 +235,7 @@ extension Club {
         if clubs.isEmpty == false {
             return clubs.first!
         } else {
-            return Club(name: name, code: code, city: city, zipCode: zipCode)
+            return Club(creator: Store.main.userId, name: name, code: code, city: city, zipCode: zipCode)
         }
     }
     

PadelClub/Data/Federal/FederalTournament.swift

@@ -20,7 +20,7 @@ struct FederalTournament: Identifiable, Codable {
         let club = DataStore.shared.user.clubsObjects().first(where: { $0.code == codeClub })
         var event = DataStore.shared.events.first(where: { $0.tenupId == id.string })
         if event == nil {
-            event = Event(creator: DataStore.shared.user.id, club: club?.id, name: libelle, tenupId: id.string)
+            event = Event(creator: Store.main.userId, club: club?.id, name: libelle, tenupId: id.string)
             do {
                 try DataStore.shared.events.addOrUpdate(instance: event!)
             } catch {

PadelClub/Views/Cashier/Event/EventCreationView.swift

@@ -130,10 +130,6 @@ struct EventCreationView: View {
     
     private func _validate() {
         let event = Event(creator: Store.main.userId, name: eventName)
-        event.club = selectedClub?.id
-        tournaments.forEach { tournament in
-            tournament.event = event.id
-        }
         
         do {
             try dataStore.events.addOrUpdate(instance: event)
@@ -142,6 +138,7 @@ struct EventCreationView: View {
         }
 
         tournaments.forEach { tournament in
+            tournament.event = event.id
             tournament.courtCount = selectedClub?.courtCount ?? 2
             tournament.startDate = startingDate
             tournament.dayDuration = duration
@@ -154,6 +151,17 @@ struct EventCreationView: View {
             Logger.error(error)
         }
 
+
+        if let selectedClub, let verifiedSelectedClubId = dataStore.clubs.first(where: { selectedClub.id == $0.id })?.id {
+            event.club = verifiedSelectedClubId
+            do {
+                try dataStore.events.addOrUpdate(instance: event)
+            } catch {
+                Logger.error(error)
+            }
+        }
+        
+
         dismiss()
         navigation.path.append(tournaments.first!)
     }

PadelClub/Views/Club/ClubDetailView.swift

@@ -53,7 +53,7 @@ struct ClubDetailView: View {
             }
 
             Section {
-                TextField("Nom du club", text: $club.name)
+                TextField("Nom du club (4 lettres mini)", text: $club.name)
                     .autocorrectionDisabled()
                     .keyboardType(.alphabet)
                     .frame(maxWidth: .infinity)
@@ -187,31 +187,6 @@ struct ClubDetailView: View {
                 }
             }
             
-            if displayContext == .addition {
-                Section {
-                } header: {
-                    HStack {
-                        VStack {
-                            Divider()
-                        }
-                        Text("ou")
-                        VStack {
-                            Divider()
-                        }
-                    }
-                }
-                
-                Section {
-                    NavigationLink {
-                        ClubSearchView(displayContext: .edition, club: club)
-                    } label: {
-                        Label("Chercher dans la base fédérale", systemImage: "magnifyingglass")
-                    }
-                } footer: {
-                    Text("Vous pouvez chercher un club dans la base fédérale et importer les informations directement.")
-                }
-            }
-            
             ClubCourtSetupView(club: club, displayContext: displayContext, selectedCourt: $selectedCourt, hideLockForEditingMessage: true)
             
             if displayContext == .edition {

PadelClub/Views/Club/ClubRowView.swift

@@ -19,7 +19,12 @@ struct ClubRowView: View {
 //                    .foregroundStyle(club.isFavorite() ? .green : .logoRed)
 //            }
         } label: {
+            HStack {
                 Text(club.name)
+                Spacer()
+            }
+            .frame(maxWidth: .infinity)
+            .contentShape(Rectangle())
         }
     }
 }

PadelClub/Views/Club/ClubsView.swift

@@ -27,6 +27,20 @@ struct ClubsView: View {
     
     var body: some View {
         List {
+            #if DEBUG
+            Section {
+                RowButtonView("Delete unexisted clubs", action: {
+                    var ids = dataStore.user.clubs
+                    ids.forEach { clubId in
+                        if dataStore.clubs.findById(clubId) == nil {
+                            dataStore.user.clubs.removeAll(where: { $0 == clubId })
+                        }
+                    }
+                    dataStore.saveUser()
+                })
+            }
+            #endif
+            
             let clubs : [Club] = dataStore.user.clubsObjects(includeCreated: false)
             let onlyCreatedClubs : [Club] = dataStore.user.createdClubsObjectsNotFavorite()
 

PadelClub/Views/Club/CreateClubView.swift

@@ -30,6 +30,10 @@ struct CreateClubView: View {
                             ProgressView()
                         } else {
                             ButtonValidateView {
+                                if club.acronym.isEmpty {
+                                    club.acronym = club.name.canonicalVersion.replaceCharactersFromSet(characterSet: .whitespacesAndNewlines).acronym()
+                                }
+                                
                                 validationInProgress = true
                             }
                             .disabled(club.isValid == false)
@@ -45,26 +49,25 @@ struct CreateClubView: View {
                                 Logger.error(error)
                             }
                             
-                            let club = Club.findOrCreate(name: club.name, code: club.code, city: club.city, zipCode: club.zipCode)
+                            let newClub = Club.findOrCreate(name: club.name, code: club.code, city: club.city, zipCode: club.zipCode)
-                            club.creator = Store.main.userId
                             
                             //update existing club if rights ok / freshly created club with data input from user
-                            if club.hasBeenCreated(by: Store.main.userId) {
+                            if newClub.hasBeenCreated(by: Store.main.userId) {
-                                club.update(fromClub: club)
+                                newClub.update(fromClub: club)
                                 do {
-                                    try dataStore.clubs.addOrUpdate(instance: club)
+                                    try dataStore.clubs.addOrUpdate(instance: newClub)
                                 } catch {
                                     Logger.error(error)
                                 }
                             }
                                                         
                             //save into user
-                            if dataStore.user.clubs.contains(where: { $0 == club.id }) == false {
+                            if dataStore.user.clubs.contains(where: { $0 == newClub.id }) == false {
-                                dataStore.user.clubs.append(club.id)
+                                dataStore.user.clubs.append(newClub.id)
                                 self.dataStore.saveUser()
                             }
                             dismiss()
-                            selection?(club)
+                            selection?(newClub)
                         }
                     }
                 }

PadelClub/Views/Navigation/MainView.swift

@@ -92,6 +92,27 @@ struct MainView: View {
         .environmentObject(dataStore)
         .task {
             await self._checkSourceFileAvailability()
+            if Store.main.hasToken() {
+                do {
+                    try await dataStore.clubs.loadDataFromServerIfAllowed()
+                } catch {
+                    Logger.error(error)
+                }
+                
+                
+                let ids = dataStore.user.clubs
+                var save = false
+                ids.forEach { clubId in
+                    if dataStore.clubs.findById(clubId) == nil {
+                        dataStore.user.clubs.removeAll(where: { $0 == clubId })
+                        save = true
+                    }
+                }
+                
+                if save {
+                    dataStore.saveUser()
+                }
+            }
         }
 //        .refreshable {
 //            Task {