diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ee2983e0..f84bd2f4 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -38,7 +38,7 @@ assembleDebug: paths: - app/build/outputs/ -debugTests: - stage: test - script: - - ./gradlew -Pci --console=plain :app:testDebug \ No newline at end of file +#debugTests: +# stage: test +# script: +# - ./gradlew -Pci --console=plain :app:testDebug diff --git a/app/build.gradle b/app/build.gradle index a8b438de..097c8efd 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -34,7 +34,7 @@ android { buildTypes { release { - minifyEnabled false + minifyEnabled true proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro' } } diff --git a/app/src/main/java/net/pokeranalytics/android/ui/activity/components/PokerAnalyticsActivity.kt b/app/src/main/java/net/pokeranalytics/android/ui/activity/components/PokerAnalyticsActivity.kt index e02ebd15..22febecc 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/activity/components/PokerAnalyticsActivity.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/activity/components/PokerAnalyticsActivity.kt @@ -18,6 +18,7 @@ open class PokerAnalyticsActivity : AppCompatActivity() { companion object { const val PERMISSION_REQUEST_ACCESS_FINE_LOCATION = 1000 + const val PLAY_SERVICES_RESOLUTION_REQUEST = 2000 } private val realm = Realm.getDefaultInstance() @@ -71,7 +72,7 @@ open class PokerAnalyticsActivity : AppCompatActivity() { /** * Return if the location permission has been granted by the user */ - fun hasLocationPermissionGranted() : Boolean { + fun hasLocationPermissionGranted(): Boolean { return ContextCompat.checkSelfPermission(this, ACCESS_FINE_LOCATION) == PackageManager.PERMISSION_GRANTED } @@ -127,21 +128,17 @@ open class PokerAnalyticsActivity : AppCompatActivity() { /** * Find the current location */ - fun findCurrentLocation(callback: ((location: Location?) -> Unit)?) { - if (LocationManager(this).databaseContainsLocationsWithCoordinates()) { - if (ContextCompat.checkSelfPermission(this, ACCESS_FINE_LOCATION) == PackageManager.PERMISSION_GRANTED) { - LocationManager(this).findNearestLocationFromUser(callback) - } else { - askForLocationPermission { granted -> - if (granted) { - LocationManager(this).findNearestLocationFromUser(callback) - } else { - callback?.invoke(null) - } + fun findCurrentLocation(callback: ((location: android.location.Location?) -> Unit)?) { + if (ContextCompat.checkSelfPermission(this, ACCESS_FINE_LOCATION) == PackageManager.PERMISSION_GRANTED) { + LocationManager(this).findCurrentLocation(callback) + } else { + askForLocationPermission { granted -> + if (granted) { + LocationManager(this).findCurrentLocation(callback) + } else { + callback?.invoke(null) } } - } else { - callback?.invoke(null) } } diff --git a/app/src/main/java/net/pokeranalytics/android/ui/fragment/LocationDataFragment.kt b/app/src/main/java/net/pokeranalytics/android/ui/fragment/LocationDataFragment.kt index 29a39585..0213d3ba 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/fragment/LocationDataFragment.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/fragment/LocationDataFragment.kt @@ -14,7 +14,6 @@ import net.pokeranalytics.android.ui.view.rowrepresentable.CustomizableRowRepres import net.pokeranalytics.android.ui.view.rowrepresentable.LocationRow import net.pokeranalytics.android.ui.view.rowrepresentable.SimpleRow import net.pokeranalytics.android.util.NULL_TEXT -import timber.log.Timber /** * Custom EditableDataFragment to manage the LOCATE_ME case @@ -181,7 +180,6 @@ class LocationDataFragment : EditableDataFragment(), StaticRowRepresentableDataS // Try to get the location of the user parentActivity.findCurrentLocation {currentLocation -> currentLocation?.let { - Timber.d("Current location: ${it.latitude}, ${it.longitude}") location.latitude = currentLocation.latitude location.longitude = currentLocation.longitude } diff --git a/app/src/main/java/net/pokeranalytics/android/util/FormatUtils.kt b/app/src/main/java/net/pokeranalytics/android/util/FormatUtils.kt index 9c9b27ad..29fbb799 100644 --- a/app/src/main/java/net/pokeranalytics/android/util/FormatUtils.kt +++ b/app/src/main/java/net/pokeranalytics/android/util/FormatUtils.kt @@ -17,5 +17,4 @@ class FormatUtils { } - } \ No newline at end of file diff --git a/app/src/test/java/net/pokeranalytics/android/ExampleUnitTest.kt b/app/src/test/java/net/pokeranalytics/android/ExampleUnitTest.kt index 9ae7c2fa..39180592 100644 --- a/app/src/test/java/net/pokeranalytics/android/ExampleUnitTest.kt +++ b/app/src/test/java/net/pokeranalytics/android/ExampleUnitTest.kt @@ -15,6 +15,8 @@ class ExampleUnitTest : RealmUnitTest() { class Grade(someValue: Double) : SessionInterface { + override var bbPer100Hands: Double = 0.0 + override var ratedNet: Double = 0.0 override var value: Double = someValue override var sessionSet: SessionSet? = SessionSet()