From 764d05c57187c936cbc28bf64262724849a63b69 Mon Sep 17 00:00:00 2001 From: Aurelien Hubert Date: Fri, 24 May 2019 12:17:41 +0200 Subject: [PATCH] Clean TODO --- .../android/ui/adapter/RowRepresentableDataSource.kt | 8 -------- .../android/ui/fragment/DataListFragment.kt | 4 ---- .../android/ui/fragment/ReportCreationFragment.kt | 4 ---- .../components/bottomsheet/BottomSheetListFragment.kt | 7 ------- 4 files changed, 23 deletions(-) diff --git a/app/src/main/java/net/pokeranalytics/android/ui/adapter/RowRepresentableDataSource.kt b/app/src/main/java/net/pokeranalytics/android/ui/adapter/RowRepresentableDataSource.kt index f02f7f96..ff8ea00e 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/adapter/RowRepresentableDataSource.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/adapter/RowRepresentableDataSource.kt @@ -30,8 +30,6 @@ interface RowRepresentableDataSource: EditableDataSource, DisplayableDataSource, */ fun viewTypeForPosition(position:Int): Int - //TODO should be removed - fun indexForRow(row: RowRepresentable): Int } /** @@ -61,12 +59,6 @@ interface StaticRowRepresentableDataSource: RowRepresentableDataSource { throw IllegalStateException("Need to implement Data Source") } - override fun indexForRow(row: RowRepresentable): Int { - this.adapterRows()?.let { - return it.indexOf(row) - } - throw IllegalStateException("Need to implement Data Source") - } } diff --git a/app/src/main/java/net/pokeranalytics/android/ui/fragment/DataListFragment.kt b/app/src/main/java/net/pokeranalytics/android/ui/fragment/DataListFragment.kt index 8b61eaf6..dc8879df 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/fragment/DataListFragment.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/fragment/DataListFragment.kt @@ -102,10 +102,6 @@ class DataListFragment : DeletableItemFragment(), LiveRowRepresentableDataSource return if (viewType != -1) viewType else RowViewType.DATA.ordinal } - override fun indexForRow(row: RowRepresentable): Int { - return this.items.indexOf(row as Identifiable) - } - override fun onRowSelected(position: Int, row: RowRepresentable, fromAction: Boolean) { when (this.dataType) { diff --git a/app/src/main/java/net/pokeranalytics/android/ui/fragment/ReportCreationFragment.kt b/app/src/main/java/net/pokeranalytics/android/ui/fragment/ReportCreationFragment.kt index 11cc28d9..ca06b1fc 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/fragment/ReportCreationFragment.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/fragment/ReportCreationFragment.kt @@ -120,10 +120,6 @@ class ReportCreationFragment : RealmFragment(), RowRepresentableDataSource, RowR } } - override fun indexForRow(row: RowRepresentable): Int { - return this.currentRows.indexOf(row) - } - override fun isSelected(row: RowRepresentable): Boolean { return this.assistant.isSelected(row) } diff --git a/app/src/main/java/net/pokeranalytics/android/ui/fragment/components/bottomsheet/BottomSheetListFragment.kt b/app/src/main/java/net/pokeranalytics/android/ui/fragment/components/bottomsheet/BottomSheetListFragment.kt index 6eaee3b8..3595e37d 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/fragment/components/bottomsheet/BottomSheetListFragment.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/fragment/components/bottomsheet/BottomSheetListFragment.kt @@ -49,13 +49,6 @@ open class BottomSheetListFragment : BottomSheetFragment(), LiveRowRepresentable return RowViewType.BOTTOM_SHEET_DATA.ordinal } - override fun indexForRow(row: RowRepresentable): Int { - realmData?.let { - return it.indexOf(row) - } - throw IllegalStateException("Need to implement Data Source") - } - override fun onRowSelected(position: Int, row: RowRepresentable, fromAction: Boolean) { realmData?.let { val selectedData = it[position]