From 739ec4129724aaac2718706751a89255cba7e32f Mon Sep 17 00:00:00 2001 From: Laurent Date: Thu, 20 Jun 2019 11:29:33 +0200 Subject: [PATCH] Slight code optimization --- .../ui/adapter/FeedSessionRowRepresentableAdapter.kt | 1 + .../adapter/FeedTransactionRowRepresentableAdapter.kt | 10 +++++----- .../pokeranalytics/android/ui/fragment/FeedFragment.kt | 2 -- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedSessionRowRepresentableAdapter.kt b/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedSessionRowRepresentableAdapter.kt index be7eed13..535958fe 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedSessionRowRepresentableAdapter.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedSessionRowRepresentableAdapter.kt @@ -177,6 +177,7 @@ class FeedSessionRowRepresentableAdapter( sortedHeaders = headersPositions.toSortedMap() + this.notifyDataSetChanged() Timber.d("Create viewTypesPositions in: ${System.currentTimeMillis() - start}ms") } diff --git a/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedTransactionRowRepresentableAdapter.kt b/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedTransactionRowRepresentableAdapter.kt index 9691d7bd..22b81ed8 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedTransactionRowRepresentableAdapter.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/adapter/FeedTransactionRowRepresentableAdapter.kt @@ -76,10 +76,10 @@ class FeedTransactionRowRepresentableAdapter( override fun getItemViewType(position: Int): Int { - if (sortedHeaders.containsKey(position)) { - return RowViewType.HEADER_TITLE.ordinal + return if (sortedHeaders.containsKey(position)) { + RowViewType.HEADER_TITLE.ordinal } else { - return RowViewType.ROW_TRANSACTION.ordinal + RowViewType.ROW_TRANSACTION.ordinal } } @@ -131,8 +131,6 @@ class FeedTransactionRowRepresentableAdapter( headersPositions.clear() - val start = System.currentTimeMillis() - var previousYear = Int.MAX_VALUE var previousMonth = Int.MAX_VALUE @@ -149,6 +147,8 @@ class FeedTransactionRowRepresentableAdapter( } sortedHeaders = headersPositions.toSortedMap() + + this.notifyDataSetChanged() } /** diff --git a/app/src/main/java/net/pokeranalytics/android/ui/fragment/FeedFragment.kt b/app/src/main/java/net/pokeranalytics/android/ui/fragment/FeedFragment.kt index a23922e8..104792b4 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/fragment/FeedFragment.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/fragment/FeedFragment.kt @@ -76,11 +76,9 @@ class FeedFragment : FilterableFragment(), RowRepresentableDelegate { when (clazz.kotlin) { Session::class -> { this.feedSessionAdapter.refreshData() - this.feedSessionAdapter.notifyDataSetChanged() } Transaction::class -> { this.feedTransactionAdapter.refreshData() - this.feedTransactionAdapter.notifyDataSetChanged() } }