From 3acb0f02ef54eb6694514e211e9a08dd995a4a83 Mon Sep 17 00:00:00 2001
From: Laurent <laurent@staxriver.com>
Date: Fri, 6 Mar 2020 11:55:42 +0100
Subject: [PATCH] Refactor the way PlayerSetups are added

---
 .../modules/handhistory/HandHistoryAdapter.kt | 118 ++++++++---------
 .../handhistory/HandHistoryFragment.kt        |  36 ++---
 .../modules/handhistory/model/ActionList.kt   |  16 +--
 .../handhistory/model/ActionReadRow.kt        |   8 +-
 .../handhistory/model/ComputedAction.kt       |  27 +---
 .../handhistory/model/HandHistoryRow.kt       |   7 +-
 .../handhistory/model/HandHistoryViewModel.kt | 123 ++++++------------
 .../handhistory/model/PlayerCardsRow.kt       |  25 ++--
 .../handhistory/model/PlayerSetupRow.kt       |  12 +-
 app/src/main/res/layout/row_hand_action.xml   |  12 +-
 .../main/res/layout/row_hand_action_read.xml  |  12 +-
 .../layout/row_hhsettings_player_setup.xml    |   6 -
 ...sition.xml => row_hhsettings_position.xml} |   1 -
 13 files changed, 168 insertions(+), 235 deletions(-)
 rename app/src/main/res/layout/{row_hhsettings_hero_position.xml => row_hhsettings_position.xml} (93%)

diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt
index e03e84b3..18f4279c 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt
@@ -21,11 +21,14 @@ import kotlinx.android.synthetic.main.row_hhsettings_player_setup.view.*
 import kotlinx.android.synthetic.main.row_hhsettings_player_setup.view.position_button
 import kotlinx.android.synthetic.main.row_hhsettings_player_setup.view.ps_hand_layout
 import kotlinx.android.synthetic.main.row_hhsettings_player_setup.view.settings_container
+import kotlinx.android.synthetic.main.row_hhsettings_player_setup.view.title
 import kotlinx.android.synthetic.main.row_hhsettings_player_setup_read.view.*
+import kotlinx.android.synthetic.main.row_hhsettings_position.view.*
 import kotlinx.android.synthetic.main.row_hhsettings_straddle.view.*
 import net.pokeranalytics.android.R
 import net.pokeranalytics.android.exceptions.PAIllegalStateException
 import net.pokeranalytics.android.model.handhistory.Position
+import net.pokeranalytics.android.model.realm.Player
 import net.pokeranalytics.android.model.realm.handhistory.Card
 import net.pokeranalytics.android.ui.adapter.BindableHolder
 import net.pokeranalytics.android.ui.adapter.RecyclerAdapter
@@ -56,7 +59,8 @@ enum class HandRowType(var layoutRes: Int) : ViewIdentifier, RowRepresentable {
 	ANTE(R.layout.row_title_value),
 	BIG_BLIND_ANTE(R.layout.row_title_switch),
 	ACTION_READ(R.layout.row_hand_action_read),
-	HERO_POSITION(R.layout.row_hhsettings_hero_position)
+	HERO_POSITION(R.layout.row_hhsettings_position),
+	PLAYER_POSITION(R.layout.row_hhsettings_position)
 	;
 
 	override val viewType: Int = this.ordinal
@@ -122,7 +126,7 @@ class HandHistoryAdapter(
 			HandRowType.PLAYER_SETUP_READ -> RowReadOnlyPlayerSetupHolder(layout)
 			HandRowType.COMMENT -> RowViewHolder(layout)
 			HandRowType.ACTION_READ -> RowActionReadHolder(layout)
-			HandRowType.HERO_POSITION -> RowPositionHolder(layout)
+			HandRowType.HERO_POSITION, HandRowType.PLAYER_POSITION -> RowPositionHolder(layout)
 			HandRowType.PLAYER_NUMBER, HandRowType.ANTE, HandRowType.BIG_BLIND_ANTE -> RowViewHolder(layout)
 		}
 	}
@@ -264,6 +268,25 @@ class HandHistoryAdapter(
 			return itemView.findViewWithTag(tag)
 		}
 
+		protected fun configurePlayerImage(playerImageView: PlayerImageView, position: Int, row: RowRepresentable) {
+
+			// Player
+			val listener = View.OnClickListener {
+				delegate?.onItemClick(position, row, playerImageView.tag as Int)
+			}
+			playerImageView.setOnImageClickListener(listener)
+
+			val size = PlayerImageView.Size.SMALL
+
+			val players = dataSource.contentForRow(row, itemView.context, Player::class)
+			if (players.isNotEmpty()) {
+				playerImageView.setPlayer(players.first(), size)
+			} else {
+				playerImageView.clear(size)
+			}
+
+		}
+
 		protected fun configureCardsLayout(layout: LinearLayout) {
 			layout.removeAllViews()
 
@@ -324,29 +347,37 @@ class HandHistoryAdapter(
 		}
 	}
 
+	inner class RowActionReadHolder(itemView: View) : RowHandHolder(itemView) {
+
+		init {
+			itemView.player_image_rhar.tag = ActionReadRow.Tag.PLAYER.ordinal
+		}
+
+		override fun onBind(position: Int, row: RowRepresentable, adapter: RecyclerAdapter) {
+
+			configurePlayerImage(itemView.player_image_rhar, position, row)
+
+			val actionReadRow = row as ActionReadRow
+			itemView.playersText.text = actionReadRow.positions.joinToString(", ") { it.value }
+			itemView.actionText.text = actionReadRow.action?.localizedTitle(itemView.context)
+			itemView.amountText.text = actionReadRow.amount?.formatted()
+
+		}
+
+	}
+
 	/**
 	 * Display a hand action
 	 */
 	inner class RowActionHolder(itemView: View) : RowHandHolder(itemView) {
 
 		init {
+			itemView.player_image_rha.tag = ComputedAction.Tag.PLAYER.ordinal
 			itemView.actionButton.tag = ComputedAction.Tag.ACTION.ordinal
 			itemView.amountEditText.tag = ComputedAction.Tag.AMOUNT.ordinal
 
 			// Action
 			setOnClickListener(itemView.actionButton)
-//			itemView.findViewById<Button>(R.id.actionButton)?.let { actionButton ->
-//
-//				setOnClickListener(actionButton)
-
-//				actionButton.setOnClickListener {
-//					actionButton.backgroundTintList = ColorStateList.valueOf(color(true))
-//
-//					val row = dataSource.rowRepresentableForPosition(currentPosition)
-//						?: throw PAIllegalStateException("Row Representable not found at index: $currentPosition")
-//					delegate?.onRowSelected(currentPosition, row, HHKeyboard.ACTION.ordinal)
-//				}
-//			}
 
 			// Amount
 			itemView.findViewById<EditText>(R.id.amountEditText)?.let { amountEditText ->
@@ -376,6 +407,8 @@ class HandHistoryAdapter(
 
 			val computedAction = row as ComputedAction
 
+			configurePlayerImage(itemView.player_image_rha, position, row)
+
 			// Position
 			itemView.findViewById<Button>(R.id.positionButton)?.let { button ->
 				button.text = computedAction.position.value
@@ -406,19 +439,6 @@ class HandHistoryAdapter(
 
 	}
 
-	inner class RowActionReadHolder(itemView: View) : RowHandHolder(itemView) {
-
-		override fun onBind(position: Int, row: RowRepresentable, adapter: RecyclerAdapter) {
-
-			val actionReadRow = row as ActionReadRow
-			itemView.playersText.text = actionReadRow.positions.joinToString(", ") { it.value }
-			itemView.actionText.text = actionReadRow.action?.localizedTitle(itemView.context)
-			itemView.amountText.text = actionReadRow.amount?.formatted()
-
-		}
-
-	}
-
 	/**
 	 * Display a hand street
 	 */
@@ -486,22 +506,6 @@ class HandHistoryAdapter(
 
 		}
 
-		protected fun configurePlayerImage(playerImageView: PlayerImageView, position: Int, row: PlayerSetupRow) {
-
-			// Player
-			val listener = View.OnClickListener {
-				delegate?.onItemClick(position, row, playerImageView.tag as Int)
-			}
-			playerImageView.setOnImageClickListener(listener)
-
-			val size = PlayerImageView.Size.SMALL
-			row.playerSetup?.player?.let { player ->
-				playerImageView.setPlayer(player, size)
-			} ?: run {
-				playerImageView.clear(size)
-			}
-
-		}
 	}
 
 	inner class RowReadOnlyPlayerSetupHolder(itemView: View) : AbstractRowHandPlayerSetup(itemView) {
@@ -545,17 +549,18 @@ class HandHistoryAdapter(
 				this.positionAdapter.notifyDataSetChanged()
 			}
 
-			val heroIndex = adapter.dataSource.intForRow(row)
-			positionAdapter.setSelectedPosition(heroIndex)
+			itemView.title.text = adapter.dataSource.charSequenceForRow(row, itemView.context)
+
+			if (row == HandRowType.HERO_POSITION) {
+				val heroIndex = adapter.dataSource.intForRow(row)
+				positionAdapter.setSelectedPosition(heroIndex)
+			}
 		}
 
 	}
 
 	inner class RowPlayerSetupHolder(itemView: View) : AbstractRowHandPlayerSetup(itemView) {
 
-		private var positionAdapter: PositionAdapter = PositionAdapter()
-		private var positionViewManager: LinearLayoutManager
-
 		init {
 
 			itemView.player_image.tag = PlayerSetupRow.Tag.PLAYER.ordinal
@@ -565,13 +570,6 @@ class HandHistoryAdapter(
 			itemView.stack_edit_text.inputType = InputType.TYPE_NUMBER_FLAG_DECIMAL
 			setClickListener(itemView.stack_edit_text)
 
-			this.positionViewManager = LinearLayoutManager(itemView.context, RecyclerView.HORIZONTAL, false)
-
-			itemView.position_recycler.apply {
-				setHasFixedSize(true)
-				layoutManager = positionViewManager
-				adapter = positionAdapter
-			}
 		}
 
 		override fun onBind(position: Int, row: RowRepresentable, adapter: RecyclerAdapter) {
@@ -588,16 +586,6 @@ class HandHistoryAdapter(
 			val visibility = if (state == PlayerSetupRow.State.SETUP_ONLY && !setupRow.hero) View.GONE else View.VISIBLE
 			itemView.title.visibility = visibility
 
-			// Position recycler
-			val posVisibility = if (state == PlayerSetupRow.State.SETUP_ONLY) View.GONE else View.VISIBLE
-			itemView.position_recycler.visibility = posVisibility
-
-			this.positionAdapter.positions = adapter.dataSource.contentForRow(row, itemView.context, Position::class)
-			this.positionAdapter.setOnClickListener { pos ->
-				setupRow.closePosition()
-				this.delegate?.onRowValueChanged(pos, row)
-			}
-
 			configureEditTexts(PlayerSetupRow.Tag.STACK.ordinal, position, row, adapter)
 
 		}
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryFragment.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryFragment.kt
index 182376c9..7d61b75d 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryFragment.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryFragment.kt
@@ -362,27 +362,31 @@ class HandHistoryFragment : RealmFragment(), RowRepresentableDelegate, KeyboardL
 					this.model.setHeroPosition(value as Position)
 					this.handHistoryAdapter.notifyItemChanged(this.indexOfRowRepresentable(row))
 				}
+				HandRowType.PLAYER_POSITION -> {
+					this.model.createPlayerSetupForPosition(value as Position)
+					this.handHistoryAdapter.notifyDataSetChanged()
+				}
 				is ComputedAction -> {
 					this.model.currentAmount = value as String
 				}
 				is StraddleRowRepresentable -> {
 					this.model.changeStraddleSelection(value as LinkedHashSet<Position>)
 				}
-				is PlayerSetupRow -> {
-					when (value) {
-						is Position -> {
-							this.model.setPlayerSetupPosition(row, value)
-							val index = this.indexOfRowRepresentable(row)
-							this.handHistoryAdapter.notifyItemChanged(index)
-
-							// Change the focus only for the row, don't look elsewhere
-//							val anyEmpty = row.tagsForCompletion().any { row.isFieldNeedsInput(it, this.model.handHistory) }
-//							if (anyEmpty) {
-//								this.findNextActionToEdit(index)
-//							}
-						}
-					}
-				}
+//				is PlayerSetupRow -> {
+//					when (value) {
+//						is Position -> {
+//							this.model.setPlayerSetupPosition(row, value)
+//							val index = this.indexOfRowRepresentable(row)
+//							this.handHistoryAdapter.notifyItemChanged(index)
+//
+//							// Change the focus only for the row, don't look elsewhere
+////							val anyEmpty = row.tagsForCompletion().any { row.isFieldNeedsInput(it, this.model.handHistory) }
+////							if (anyEmpty) {
+////								this.findNextActionToEdit(index)
+////							}
+//						}
+//					}
+//				}
 			}
 
 		}
@@ -394,7 +398,7 @@ class HandHistoryFragment : RealmFragment(), RowRepresentableDelegate, KeyboardL
 			is PlayerSetupRow -> {
 				when (tag) {
 					PlayerSetupRow.Tag.PLAYER.ordinal -> {
-						this.model.clickPosition = position
+						this.model.clickPlayerPosition = position
 						DataListActivity.newDialogInstance(this, LiveData.PLAYER, true)
 					}
 					else -> {
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionList.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionList.kt
index b650afb4..998cf191 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionList.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionList.kt
@@ -271,7 +271,7 @@ class ActionList(var listener: ActionListListener) : ArrayList<ComputedAction>()
 	private fun getLastPlayerAction(index: Int): ComputedAction? {
 		val action = this[index].action
 		val previousActions = this.take(index)
-		return previousActions.lastOrNull { it.action.position == action.position }
+		return previousActions.lastOrNull { it.positionIndex == action.position }
 	}
 
 	/***
@@ -473,7 +473,7 @@ class ActionList(var listener: ActionListListener) : ArrayList<ComputedAction>()
 			created = true
 		}
 
-		playerSetup.stack = this.filter { it.action.position == positionIndex }.sumByDouble { it.action.effectiveAmount }
+		playerSetup.stack = this.filter { it.positionIndex == positionIndex }.sumByDouble { it.action.effectiveAmount }
 
 		if (created) {
 			this.listener.playerSetupCreated()
@@ -500,7 +500,7 @@ class ActionList(var listener: ActionListListener) : ArrayList<ComputedAction>()
 	 * Returns whether the player at [position] is all-in and its amount is set
 	 */
 	fun isPlayerAllinWithAmount(position: Int): Boolean {
-		val computedAction = this.lastOrNull { it.action.position == position && it.action.type?.isAllin == true }
+		val computedAction = this.lastOrNull { it.positionIndex == position && it.action.type?.isAllin == true }
 		return computedAction?.action?.amount != null
 	}
 
@@ -607,17 +607,17 @@ class ActionList(var listener: ActionListListener) : ArrayList<ComputedAction>()
 	}
 
 	/***
-	 * Recomputes all remaining stacks for the given [positions]
+	 * Recomputes all remaining stacks for the given [positionIndexes]
 	 */
-	fun updateRemainingStacksForPositions(positions: List<Int>) {
+	fun updateRemainingStacksForPositions(positionIndexes: List<Int>) {
 
 		val ante = if (this.handHistory.bigBlindAnte) this.handHistory.bigBlind ?: 0.0 else this.handHistory.ante
 
-		positions.forEach { position ->
-			this.handHistory.playerSetupForPosition(position)?.stack?.let { initialStack ->
+		positionIndexes.forEach { posIndex ->
+			this.handHistory.playerSetupForPosition(posIndex)?.stack?.let { initialStack ->
 
 				var remainingStack = initialStack - ante
-				val playerActions = this.filter { it.action.position == position }
+				val playerActions = this.filter { it.positionIndex == posIndex }
 				playerActions.forEach {
 					remainingStack -= it.action.effectiveAmount
 					it.playerRemainingStack = remainingStack
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionReadRow.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionReadRow.kt
index 223efc38..7b1e97d8 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionReadRow.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ActionReadRow.kt
@@ -5,7 +5,13 @@ import net.pokeranalytics.android.model.realm.handhistory.Action
 import net.pokeranalytics.android.ui.modules.handhistory.HandRowType
 import net.pokeranalytics.android.ui.view.RowRepresentable
 
-class ActionReadRow(var positions: MutableList<Position>, var action: Action.Type?, var amount: Double?) : RowRepresentable {
+class ActionReadRow(var positions: MutableList<Position>,
+                    var action: Action.Type?,
+                    var amount: Double?) : RowRepresentable {
+
+	enum class Tag {
+		PLAYER
+	}
 
 	override val viewType: Int = HandRowType.ACTION_READ.ordinal
 
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ComputedAction.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ComputedAction.kt
index 89ac56e3..efead9cc 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ComputedAction.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/ComputedAction.kt
@@ -34,9 +34,10 @@ class ComputedAction(var manager: ActionManager,
                      var totalPotSize: Double = 0.0,
                      var playerRemainingStack: Double? = null,
                      var position: Position
-) : HandHistoryRow {
+) : HandHistoryRow, PositionalRow {
 
 	enum class Tag {
+		PLAYER,
 		ACTION,
 		AMOUNT
 	}
@@ -177,27 +178,6 @@ class ComputedAction(var manager: ActionManager,
 		}
 	}
 
-	/***
-	 * Returns a keyboard to complete the action, or null if the action is filled
-	 * All ComputedAction should have a type, so we return the action keyboard if the type is null
-	 * If the action has a type, we return the amount keyboard if the action requires one
-	 */
-//	override fun tagForCompletion(
-//		handHistory: HandHistory,
-//		minTag: Int?
-//	): Int? {
-//		Timber.d("index = ${action.index} / type = ${this.action.type} / amount = ${this.action.amount}")
-//		return if (this.action.type != null) {
-//			if (this.requiresAmount) {
-//				Tag.AMOUNT.ordinal
-//			} else {
-//				null
-//			}
-//		} else {
-//			Tag.ACTION.ordinal
-//		}
-//	}
-
 	override fun isFieldNeedsInput(tag: Int, handHistory: HandHistory): Boolean {
 		return when (tag) {
 			Tag.ACTION.ordinal -> this.action.type == null
@@ -300,4 +280,7 @@ class ComputedAction(var manager: ActionManager,
 		return ActionReadRow(mutableListOf(this.position), this.action.type, this.action.amount)
 	}
 
+	override val positionIndex: Int
+		get() { return this.action.position }
+
 }
\ No newline at end of file
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryRow.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryRow.kt
index 3191afbc..f0a957f1 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryRow.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryRow.kt
@@ -3,7 +3,6 @@ package net.pokeranalytics.android.ui.modules.handhistory.model
 import net.pokeranalytics.android.model.realm.handhistory.HandHistory
 import net.pokeranalytics.android.ui.view.RowRepresentable
 
-
 interface HandHistoryRow : RowRepresentable {
 
 	fun isFieldNeedsInput(tag: Int, handHistory: HandHistory): Boolean
@@ -15,4 +14,8 @@ interface HandHistoryRow : RowRepresentable {
 	fun amountForTag(handHistory: HandHistory, tag: Int): Double? { return null }
 
 	fun onSelect(tag: Int) {}
-}
\ No newline at end of file
+}
+
+interface PositionalRow {
+	val positionIndex: Int
+}
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryViewModel.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryViewModel.kt
index 88898b83..5b94e746 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryViewModel.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/HandHistoryViewModel.kt
@@ -12,7 +12,10 @@ import net.pokeranalytics.android.model.handhistory.Position
 import net.pokeranalytics.android.model.handhistory.Street
 import net.pokeranalytics.android.model.realm.Player
 import net.pokeranalytics.android.model.realm.Session
-import net.pokeranalytics.android.model.realm.handhistory.*
+import net.pokeranalytics.android.model.realm.handhistory.Action
+import net.pokeranalytics.android.model.realm.handhistory.Card
+import net.pokeranalytics.android.model.realm.handhistory.HandHistory
+import net.pokeranalytics.android.model.realm.handhistory.formatted
 import net.pokeranalytics.android.ui.adapter.RowRepresentableDataSource
 import net.pokeranalytics.android.ui.modules.handhistory.HandRowType
 import net.pokeranalytics.android.ui.modules.handhistory.views.CardCentralizer
@@ -125,7 +128,7 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 	/***
 	 * The position of a click
 	 */
-	var clickPosition: Int? = null
+	var clickPlayerPosition: Int? = null
 
 	/***
 	 * The board cards sorted by position
@@ -244,7 +247,6 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 								position,
 								positionIndex,
 								this.handHistory,
-								this.handHistory.playerSetupForPosition(positionIndex),
 								this.playerHandMaxCards)
 							rows.add(playerCardsRow)
 						}
@@ -288,8 +290,14 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 			rows.add(StraddleRowRepresentable(positions, this.straddlePositions))
 		}
 
+		// Used to set the hero position
 		rows.add(HandRowType.HERO_POSITION)
 
+		// Used to select an available position to set details for that position
+		if (this.handHistory.playerSetups.size < this.handHistory.numberOfPlayers) {
+			rows.add(HandRowType.PLAYER_POSITION)
+		}
+
 		this.playerSetups().forEach {
 			rows.add(it)
 		}
@@ -312,7 +320,6 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 								position,
 								positionIndex,
 								this.handHistory,
-								this.handHistory.playerSetupForPosition(positionIndex),
 								this.playerHandMaxCards)
 							rows.add(playerCardsRow)
 						}
@@ -428,12 +435,6 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 				}
 
 			}
-//			if (index >= startIndex && rowRepresentable is HandHistoryRow) {
-//				val tag = rowRepresentable.tagForCompletion(this.handHistory, minTag)
-//				if (tag != null) {
-//					return HHSelection(index, tag)
-//				}
-//			}
 		}
 		return null
 	}
@@ -470,19 +471,6 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 
 		val row = this.rowRepresentables[this.currentSelection.index]
 		when (row) {
-//			HandRowType.BLINDS -> {
-//				when (this.currentSelection.tag) {
-//					0 -> {
-//						this.handHistory.smallBlind = amount
-//						this.sortedActions.updateBlinds()
-//					}
-//					1 -> {
-//						this.handHistory.bigBlind = amount
-//						this.sortedActions.updateBlinds()
-//					}
-//					2 -> this.handHistory.ante = amount ?: 0.0
-//				}
-//			}
 			is ComputedAction -> {
 				amount?.let {
 					this.sortedActions.setAmount(this.actionIndexForSelection, amount)
@@ -685,9 +673,7 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 			is PlayerSetupRow -> {
 				when (tag) {
 					PlayerSetupRow.Tag.STACK.ordinal -> {
-						row.playerSetup?.position?.let {
-							!this.sortedActions.isPlayerAllinWithAmount(it)
-						} ?: run { true }
+						!this.sortedActions.isPlayerAllinWithAmount(row.positionIndex)
 					}
 					else -> true
 				}
@@ -707,7 +693,6 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 	override fun isFocusable(position: Int, row: RowRepresentable, tag: Int): Boolean {
 
 		return when (row) {
-//			HandRowType.BLINDS -> this.isSelected(position, row, tag)
 			is ComputedAction -> {
 				val isSelected = this.isSelected(position, row, tag)
 				when (tag) {
@@ -735,19 +720,13 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 			HandRowType.PLAYER_NUMBER -> this.handHistory.numberOfPlayers.toString()
 			HandRowType.COMMENT -> this.handHistory.comment ?: context.getString(R.string.comment)
 			HandRowType.ANTE -> this.handHistory.ante.formatted()
-//			HandRowType.BLINDS -> {
-//				when (tag) {
-//					0 -> this.handHistory.smallBlind?.formatted()
-//					1 -> this.handHistory.bigBlind?.formatted()
-//					2 -> this.handHistory.ante.formatted()
-//					else -> throw PAIllegalStateException("Unmanaged case with $row, tag = $tag")
-//				}
-//			}
+			HandRowType.HERO_POSITION -> context.getString(R.string.set_hero_position)
+			HandRowType.PLAYER_POSITION -> context.getString(R.string.set_position_details)
 			is ComputedAction -> row.action.formattedAmount
 			is StreetCardsRow -> row.cardsForTag(tag)?.formatted(context)
 			is PlayerSetupRow -> {
 				when (tag) {
-					PlayerSetupRow.Tag.POSITION.ordinal -> row.position?.value
+					PlayerSetupRow.Tag.POSITION.ordinal -> row.position.value
 					PlayerSetupRow.Tag.HAND.ordinal -> row.cardHolder?.cards?.formatted(context)
 					PlayerSetupRow.Tag.STACK.ordinal -> row.playerSetup?.stack?.formatted()
 					else -> throw PAIllegalStateException("Unmanaged case with $row, tag = $tag")
@@ -764,10 +743,13 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 	override fun <T : Any> contentForRow(row: RowRepresentable, context: Context, clazz: KClass<T>) : List<T> {
 		when (clazz) {
 			Position::class -> {
-				return this.handHistory.undefinedPositions() as List<T>
+				return when (row) {
+					HandRowType.HERO_POSITION -> this.sortedActions.positions.toList() as List<T>
+					HandRowType.PLAYER_POSITION -> this.handHistory.undefinedPositions() as List<T>
+					else -> throw PAIllegalStateException("undefined contentForRow:Position for $row")
+				}
 			}
 			Card::class -> {
-
 				val cards = when (row) {
 					is StreetCardsRow -> {
 						this.handHistory.cardsForStreet(row.street)
@@ -782,6 +764,11 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 				}
 				return (cards ?: listOf<Card>()) as List<T>
 			}
+			Player::class -> {
+				val position = (row as PositionalRow).positionIndex
+				val player = this.handHistory.playerSetupForPosition(position)?.player
+				return player?.let { listOf(it) as List<T> } ?: listOf()
+			}
 		}
 		return listOf()
 	}
@@ -837,7 +824,7 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 		val hh = this.handHistory
 		return hh.playerSetups.sortedBy { it.position }.map {
 			val position = this.positionForIndex(it.position)
-			createPlayerSetupRow(it, position, hero = false, readMode = true)
+			createPlayerSetupRow(position, it.position, hero = false, readMode = true)
 		}
 	}
 
@@ -851,27 +838,15 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 		val hh = this.handHistory
 
 		val arrangedSetups = mutableListOf<PlayerSetupRow>()
-		if (hh.playerSetups.size < hh.numberOfPlayers) {
-			arrangedSetups.add(createPlayerSetupRow(hero = false))
-		}
 
 		val existingSetups = hh.playerSetups.sortedBy { it.position }.map {
 			val position = this.positionForIndex(it.position)
 			val hero = (it.position == hh.heroIndex)
-			createPlayerSetupRow(it, position, hero)
+			createPlayerSetupRow(position, it.position, hero)
 		}
 
 		arrangedSetups.addAll(existingSetups)
 
-//		val heroSetup = arrangedSetups.firstOrNull { it.playerSetup?.position == hh.heroIndex }
-//		heroSetup?.let {
-//			it.hero = true
-//			arrangedSetups.remove(it)
-//			arrangedSetups.add(0, it)
-//		} ?: run {
-//			arrangedSetups.add(0, createPlayerSetupRow(hero = true))
-//		}
-
 		return arrangedSetups
 	}
 
@@ -879,43 +854,23 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 	 * Convenience method to create a PlayerSetupRow
 	 */
 	private fun createPlayerSetupRow(
-		playerSetup: PlayerSetup? = null,
-		position: Position? = null,
+		position: Position,
+		positionIndex: Int,
 		hero: Boolean,
 		readMode: Boolean = false
 	): PlayerSetupRow {
-		return PlayerSetupRow(hero, readMode, position, playerSetup?.position, this.handHistory, playerSetup, this.playerHandMaxCards)
+		return PlayerSetupRow(hero, readMode, position, positionIndex, this.handHistory, this.playerHandMaxCards)
 	}
 
 	/***
 	 * Sets both positionIndex and [position] for a PlayerSetup inside a [playerSetupRow]
 	 */
-	fun setPlayerSetupPosition(playerSetupRow: PlayerSetupRow, position: Position) {
-
+	fun createPlayerSetupForPosition(position: Position) {
 		val positionIndex = this.sortedActions.positions.indexOf(position)
-		var setupCreated = false
-		playerSetupRow.playerSetup?.let { playerSetup ->
-			playerSetup.position = positionIndex
-		} ?: run {
-			playerSetupRow.playerSetup = this.handHistory.createPlayerSetup(positionIndex)
-			setupCreated = true
-		}
-
-		playerSetupRow.position = position
-
-		if (!playerSetupRow.hero && setupCreated) {
-
-			if (this.handHistory.undefinedPositions().isNotEmpty()) {
-				val newPlayerRow = createPlayerSetupRow(hero = false)
-				val index = this.indexOfRowRepresentable(playerSetupRow)
-				this.rowsLiveData.value?.add(index + 1, newPlayerRow)
-			}
-		}
-
-		if (playerSetupRow.hero) {
-			this.handHistory.heroIndex = positionIndex
-		}
+		this.handHistory.createPlayerSetup(positionIndex)
 
+		// refresh rows
+		this.createRowRepresentation()
 	}
 
 	/***
@@ -926,7 +881,7 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 	}
 
 	/***
-	 * Sets the ante value
+	 * Sets the [ante] value
 	 */
 	fun setAnte(ante: Double) {
 		this.handHistory.ante = ante
@@ -943,8 +898,11 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 		this.sortedActions.updateBigBlindRemainingStack()
 	}
 
+	/***
+	 * Defines the [player] at the saved [clickPlayerPosition]
+	 */
 	fun playerSelected(player: Player) {
-		this.clickPosition?.let { position ->
+		this.clickPlayerPosition?.let { position ->
 
 			when (val row = this.rowRepresentables[position]) {
 				is PlayerSetupRow -> {
@@ -958,6 +916,9 @@ class HandHistoryViewModel : ViewModel(), RowRepresentableDataSource, CardCentra
 		} ?: throw PAIllegalStateException("Click position not set for player selection")
 	}
 
+	/***
+	 * Sets the heroIndex based on the given [position]
+	 */
 	fun setHeroPosition(position: Position) {
 		this.handHistory.heroIndex = this.sortedActions.positions.indexOf(position)
 	}
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerCardsRow.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerCardsRow.kt
index 804b308d..1a7d354b 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerCardsRow.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerCardsRow.kt
@@ -1,39 +1,33 @@
 package net.pokeranalytics.android.ui.modules.handhistory.model
 
 import io.realm.Realm
-import net.pokeranalytics.android.exceptions.PAIllegalStateException
 import net.pokeranalytics.android.model.handhistory.Position
 import net.pokeranalytics.android.model.realm.handhistory.HandHistory
 import net.pokeranalytics.android.model.realm.handhistory.PlayerSetup
 import net.pokeranalytics.android.ui.modules.handhistory.HandRowType
 
 open class PlayerCardsRow(private var playerSetupCreationListener: PlayerSetupCreationListener?,
-                          var position: Position?,
-                          private var positionIndex: Int?,
+                          var position: Position,
+                          override var positionIndex: Int,
                           private var handHistory: HandHistory,
-                          var playerSetup: PlayerSetup?,
-                          var maxCards: Int? = null) : CardsRow() {
+                          var maxCards: Int? = null) : CardsRow(), PositionalRow {
 
-	constructor(position: Position?,
-	            positionIndex: Int?,
+	constructor(position: Position,
+	            positionIndex: Int,
 	            handHistory: HandHistory,
-	            playerSetup: PlayerSetup?,
-	            maxCards: Int? = null) : this(null, position, positionIndex, handHistory, playerSetup, maxCards)
+	            maxCards: Int? = null) : this(null, position, positionIndex, handHistory, maxCards)
 
 	enum class Tag {
 		CARDS
 	}
 
 	override val cardHolder: CardHolder?
-		get() { return this.playerSetup }
+		get() { return this.handHistory.playerSetupForPosition(this.positionIndex) }
 
 	override val viewType: Int = HandRowType.PLAYER_SUMMARY.ordinal
 
 	override fun createHolder() {
-		val position = this.positionIndex
-			?: throw PAIllegalStateException("Can't create a PlayerSetup without a position")
-
-		this.playerSetup = this.handHistory.createPlayerSetup(position)
+		this.handHistory.createPlayerSetup(this.positionIndex)
 	}
 
 	override fun cardLimit() : Int? {
@@ -51,4 +45,7 @@ open class PlayerCardsRow(private var playerSetupCreationListener: PlayerSetupCr
 		return listOf(Tag.CARDS.ordinal)
 	}
 
+	val playerSetup: PlayerSetup?
+		get() { return this.handHistory.playerSetupForPosition(this.positionIndex) }
+
 }
\ No newline at end of file
diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerSetupRow.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerSetupRow.kt
index c4c4353c..4fcaff3d 100644
--- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerSetupRow.kt
+++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/model/PlayerSetupRow.kt
@@ -5,17 +5,15 @@ import net.pokeranalytics.android.R
 import net.pokeranalytics.android.exceptions.PAIllegalStateException
 import net.pokeranalytics.android.model.handhistory.Position
 import net.pokeranalytics.android.model.realm.handhistory.HandHistory
-import net.pokeranalytics.android.model.realm.handhistory.PlayerSetup
 import net.pokeranalytics.android.ui.modules.handhistory.HandRowType
 
 class PlayerSetupRow(var hero: Boolean = false,
-                     var readMode: Boolean = false,
-                     position: Position?,
-                     positionIndex: Int?,
+                     private var readMode: Boolean = false,
+                     position: Position,
+                     positionIndex: Int,
                      handHistory: HandHistory,
-                     playerSetup: PlayerSetup?,
                      maxCards: Int? = null) :
-	PlayerCardsRow(position, positionIndex, handHistory, playerSetup, maxCards) {
+	PlayerCardsRow(position, positionIndex, handHistory, maxCards) {
 
 	enum class State {
 		POSITIONS_ONLY,
@@ -52,7 +50,7 @@ class PlayerSetupRow(var hero: Boolean = false,
 				setup.player?.name?.let {
 					it
 				} ?: run {
-					this.position?.value
+					this.position.value
 				}
 			} ?: run {
 				context.getString(R.string.set_position_details)
diff --git a/app/src/main/res/layout/row_hand_action.xml b/app/src/main/res/layout/row_hand_action.xml
index 3a474fed..55520772 100644
--- a/app/src/main/res/layout/row_hand_action.xml
+++ b/app/src/main/res/layout/row_hand_action.xml
@@ -4,12 +4,12 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content">
 
-    <com.google.android.material.button.MaterialButton
-        android:id="@+id/player_button"
-        style="@style/PokerAnalyticsTheme.HHButton"
-        android:layout_width="44dp"
-        android:layout_height="44dp"
-        android:layout_marginStart="8dp"/>
+    <net.pokeranalytics.android.ui.view.PlayerImageView
+        android:id="@+id/player_image_rha"
+        android:layout_marginStart="8dp"
+        android:layout_width="48dp"
+        android:layout_height="48dp"
+        android:background="@android:color/transparent" />
 
     <com.google.android.material.button.MaterialButton
         android:id="@+id/positionButton"
diff --git a/app/src/main/res/layout/row_hand_action_read.xml b/app/src/main/res/layout/row_hand_action_read.xml
index 8a7f36a8..5b4e1872 100644
--- a/app/src/main/res/layout/row_hand_action_read.xml
+++ b/app/src/main/res/layout/row_hand_action_read.xml
@@ -5,12 +5,12 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content">
 
-    <com.google.android.material.button.MaterialButton
-        android:id="@+id/player_button"
-        style="@style/PokerAnalyticsTheme.HHButton"
-        android:layout_width="44dp"
-        android:layout_height="44dp"
-        android:layout_marginStart="8dp"/>
+    <net.pokeranalytics.android.ui.view.PlayerImageView
+        android:id="@+id/player_image_rhar"
+        android:layout_marginStart="8dp"
+        android:layout_width="48dp"
+        android:layout_height="48dp"
+        android:background="@android:color/transparent" />
 
     <androidx.appcompat.widget.AppCompatTextView
         android:id="@+id/playersText"
diff --git a/app/src/main/res/layout/row_hhsettings_player_setup.xml b/app/src/main/res/layout/row_hhsettings_player_setup.xml
index 96f0aed8..1bcfbef7 100644
--- a/app/src/main/res/layout/row_hhsettings_player_setup.xml
+++ b/app/src/main/res/layout/row_hhsettings_player_setup.xml
@@ -12,12 +12,6 @@
         android:layout_marginTop="8dp"
         android:layout_marginStart="8dp" />
 
-    <androidx.recyclerview.widget.RecyclerView
-        android:id="@+id/position_recycler"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        />
-
     <LinearLayout
         android:id="@+id/settings_container"
         android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/row_hhsettings_hero_position.xml b/app/src/main/res/layout/row_hhsettings_position.xml
similarity index 93%
rename from app/src/main/res/layout/row_hhsettings_hero_position.xml
rename to app/src/main/res/layout/row_hhsettings_position.xml
index d8d55109..8b7eca64 100644
--- a/app/src/main/res/layout/row_hhsettings_hero_position.xml
+++ b/app/src/main/res/layout/row_hhsettings_position.xml
@@ -6,7 +6,6 @@
 
     <androidx.appcompat.widget.AppCompatTextView
         android:id="@+id/title"
-        android:text="@string/set_hero_position"
         style="@style/PokerAnalyticsTheme.TextView.RowTitle"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"