From 06d948305464aeac32fe0ab5192c0b41c065653c Mon Sep 17 00:00:00 2001 From: Laurent Date: Wed, 1 Jul 2020 10:16:11 +0200 Subject: [PATCH] Get better logs if crash --- app/build.gradle | 2 +- .../android/ui/modules/handhistory/HandHistoryAdapter.kt | 7 +++++-- app/standard/release/output.json | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index d45dfa0a..c5a39eeb 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -34,7 +34,7 @@ android { applicationId "net.pokeranalytics.android" minSdkVersion 23 targetSdkVersion 28 - versionCode 89 + versionCode 91 versionName "5.0_alpha_1" testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } diff --git a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt index de9ea1df..06498716 100644 --- a/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt +++ b/app/src/main/java/net/pokeranalytics/android/ui/modules/handhistory/HandHistoryAdapter.kt @@ -269,7 +269,9 @@ class HandHistoryAdapter( } val row = dataSource.rowRepresentableForPosition(currentPosition) ?: throw PAIllegalStateException("Row Representable not found at index: $currentPosition") - delegate?.onItemClick(currentPosition, row, button.tag as Int) + + val tag = button.tag as? Int ?: throw PAIllegalStateException("Button has no tag, text: ${button.text}, ref: $button") + delegate?.onItemClick(currentPosition, row, tag) } } @@ -289,7 +291,8 @@ class HandHistoryAdapter( // Player val listener = View.OnClickListener { - delegate?.onItemClick(position, row, playerImageView.tag as Int) + val tag = playerImageView.tag as? Int ?: throw PAIllegalStateException("playerImageView has no tag, position: $position, row: $row, ref: $playerImageView") + delegate?.onItemClick(position, row, tag) } playerImageView.setOnImageClickListener(listener) diff --git a/app/standard/release/output.json b/app/standard/release/output.json index bcdcb022..f881e5c8 100644 --- a/app/standard/release/output.json +++ b/app/standard/release/output.json @@ -1 +1 @@ -[{"outputType":{"type":"APK"},"apkData":{"type":"MAIN","splits":[],"versionCode":89,"versionName":"5.0_alpha_1","enabled":true,"outputFile":"PokerAnalytics_5.0_alpha_1(89)_200625_1422_release.apk","fullName":"standardRelease","baseName":"standard-release","dirName":""},"path":"PokerAnalytics_5.0_alpha_1(89)_200625_1422_release.apk","properties":{}}] \ No newline at end of file +[{"outputType":{"type":"APK"},"apkData":{"type":"MAIN","splits":[],"versionCode":90,"versionName":"5.0_alpha_1","enabled":true,"outputFile":"PokerAnalytics_5.0_alpha_1(90)_200701_0910_release.apk","fullName":"standardRelease","baseName":"standard-release","dirName":""},"path":"PokerAnalytics_5.0_alpha_1(90)_200701_0910_release.apk","properties":{}}] \ No newline at end of file